Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

cluster: ignore no tispark master error when listing clusters #920

Merged
merged 1 commit into from
Nov 19, 2020
Merged

cluster: ignore no tispark master error when listing clusters #920

merged 1 commit into from
Nov 19, 2020

Conversation

AstroProfundis
Copy link
Contributor

What problem does this PR solve?

Fix #909

What is changed and how it works?

Ignore no tispark master error when listing clusters

Check List

Tests

  • Manual test (add detailed scripts or steps below)

Code changes

  • Has exported function/method change

Related changes

  • Need to cherry-pick to the release branch

Release notes:

cluster: ignore no tispark master error when listing installed clusters

@AstroProfundis AstroProfundis added the type/bug-fix Categorizes PR as a bug-fix label Nov 19, 2020
@AstroProfundis AstroProfundis self-assigned this Nov 19, 2020
@codecov-io
Copy link

Codecov Report

Merging #920 (fdda574) into master (bd9a03a) will increase coverage by 0.05%.
The diff coverage is 62.50%.

Impacted file tree graph

@@            Coverage Diff             @@
##           master     #920      +/-   ##
==========================================
+ Coverage   53.09%   53.14%   +0.05%     
==========================================
  Files         260      260              
  Lines       18941    18946       +5     
==========================================
+ Hits        10056    10069      +13     
+ Misses       7340     7336       -4     
+ Partials     1545     1541       -4
Flag Coverage Δ
cluster 45.19% <62.50%> (+0.08%) ⬆️
dm 25.03% <62.50%> (-0.05%) ⬇️
integrate 47.74% <62.50%> (+0.05%) ⬆️
playground 22.09% <ø> (ø)
tiup 10.67% <ø> (ø)
unittest 21.51% <0.00%> (-0.01%) ⬇️

Flags with carried forward coverage won't be shown. Click here to find out more.

Impacted Files Coverage Δ
pkg/cluster/manager.go 67.63% <62.50%> (+0.26%) ⬆️
pkg/cluster/api/dmapi.go 58.26% <0.00%> (-1.74%) ⬇️
pkg/cluster/api/pdapi.go 61.30% <0.00%> (+1.23%) ⬆️
pkg/cluster/api/binlog.go 38.93% <0.00%> (+1.76%) ⬆️
pkg/utils/http_client.go 72.22% <0.00%> (+5.55%) ⬆️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update bd9a03a...fdda574. Read the comment docs.

lucklove
lucklove approved these changes Nov 19, 2020
View reviewed changes
Copy link
Member

@lucklove lucklove left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@ti-srebot ti-srebot added the status/LGT1 Indicates that a PR has LGTM 1. label Nov 19, 2020
@lucklove lucklove merged commit afcaf6f into pingcap:master Nov 19, 2020
@lucklove lucklove added this to the v1.2.4 milestone Nov 19, 2020
lucklove pushed a commit that referenced this pull request Nov 19, 2020
@AstroProfundis @lucklove
cluster: ignore no tispark master error when listing and scaling in c…
a69cef2 
…lusters (#920)
@AstroProfundis AstroProfundis deleted the fix-909 branch November 19, 2020 10:50
@AstroProfundis AstroProfundis mentioned this pull request Nov 20, 2020
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@lucklove lucklove lucklove approved these changes

Assignees

@AstroProfundis AstroProfundis

Labels
status/LGT1 Indicates that a PR has LGTM 1. type/bug-fix Categorizes PR as a bug-fix
Projects
None yet
Milestone
v1.2.4
Development

Successfully merging this pull request may close these issues.

Failed to list cluster if there is an error of topology validate
4 participants
@AstroProfundis @codecov-io @lucklove @ti-srebot